Add msg_send_id!
#120
Merged
Add msg_send_id!
#120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
smart-msg-send
branch
from
a09e9f3
to
7273966
Compare
This comment was marked as outdated.
This comment was marked as outdated.
madsmtm
force-pushed
the
optimized-autorelease-retain
branch
3 times, most recently
from
b5297b9
to
908f914
Compare
madsmtm
force-pushed
the
optimized-autorelease-retain
branch
2 times, most recently
from
597c950
to
e149351
Compare
madsmtm
force-pushed
the
smart-msg-send
branch
2 times, most recently
from
3524bdb
to
8770954
Compare
Merged
madsmtm
force-pushed
the
smart-msg-send
branch
3 times, most recently
from
cb29636
to
75c2f1e
Compare
This was referenced Jun 15, 2022
Merged
Assert -> RetainSemantics in_method_family -> in_selector_family
madsmtm
force-pushed
the
smart-msg-send
branch
2 times, most recently
from
1909ca5
to
14a4fd2
Compare
It makes error messages and documentation worse (which _is_ a big deal), and I doubt it'll really be useful. Besides, we can always re-add it without breaking changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
msg_send_id!to help with following memory management rules (see also this).Closes #86.
TODO:
Id::retain_autoreleased#81.msg_send!is done #150.blocked on Add test helper.RcTestObjectto test that reference counting works properly #166allocreturnOption<Id<Allocated<T>, O>>, and just allow passing that toinit, or should we handle it?It should and now does.
__MsgSendId/__MsgSuperSendIdcan only be implemented for one type pr.__Allocated<...>, which may be better?)Consider usingMaybeUninitinstead ofAllocated?Nope, see Add
rc::Unknownandrc::MaybeOwnership#87 (comment)supercallssuperinmsg_send_id!#173rc::Allocated<T>to Addrc::Allocated#172 to get this merged.initshould take genericInto<Option>, or justOption.