Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace IE11 by edge/chromium to support ECMA6 [feature request] #213

Open
mprevot opened this issue Jan 5, 2021 · 6 comments
Open

replace IE11 by edge/chromium to support ECMA6 [feature request] #213

mprevot opened this issue Jan 5, 2021 · 6 comments

Comments

@mprevot
Copy link

mprevot commented Jan 5, 2021

Installed product versions

  • Visual Studio: 16.8.3 enterprise
  • This extension: 1.12.253

Description

MarkdownEditor uses VS2019 integrated IE11 but IE11 does not support ECMA6 js, excluding a class of js plugins such as mermaid (mermaid-js/mermaid#303).

Using Edge/Chromium instead would be neat for features/performance/maintenance.

Chromium Embedded Framework (CEF) can be used (~ Chromium v88.0.4324.0):
https://github.com/chromiumembedded/cef

@efreykongcn
Copy link
Contributor

efreykongcn commented Feb 4, 2022

Hi,

I've implemented this feature for my personal use (Replaced IE 11 by Microsoft Edge WebView2 instead of CEF). Now the browser supports latest mermaid (v8.13.10. Sequence diagram etc.).

I'm not sure this feature would be a common request, so I just keep it in my forked repository, UpgradeBrowserToWebView2 branch.

Anyone who may interested this feature can get it from branch link: https://github.com/efreykongcn/MarkdownEditor/tree/UpgradeBrowserToWebView2

@madskristensen
Copy link
Owner

How much bigger is the .vsix file with WebView2?

@efreykongcn
Copy link
Contributor

How much bigger is the .vsix file with WebView2?

The size of current MarkdownEditor.vsix is 1.68MB, after upgraded browser from IE to WebView2 (also upgraded mermaid js to the latest), the vsix file is about 2.84MB.

@madskristensen
Copy link
Owner

A PR with this would be awesome if you're willing?

@efreykongcn
Copy link
Contributor

A PR with this would be awesome if you're willing?

My pleasure.
PR created. Please review.

@ite-klass
Copy link

This was implemented in #229, merged in c9d7762.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants