Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Postgres and start passing CancellationToken to PrepareAsync() if issue is resolved #111

Closed
madelson opened this issue Dec 13, 2021 · 4 comments
Closed

Upgrade Postgres and start passing CancellationToken to PrepareAsync() if issue is resolved #111

madelson opened this issue Dec 13, 2021 · 4 comments
Assignees
@Bartleby2718
Labels
cleanup Code cleanup and other maintenance changes that do not affect runtime behavior
Milestone
2.4

Comments

@madelson
Copy link
Owner

See npgsql/npgsql#4209
@madelson madelson added the cleanup Code cleanup and other maintenance changes that do not affect runtime behavior label Dec 13, 2021
@madelson madelson changed the title Upgrade Postgres and start passing CancellationToken to PrepareAsync() once issue is resolved Upgrade Postgres and start passing CancellationToken to PrepareAsync() if issue is resolved Dec 13, 2021
@M4urici0GM
Copy link

Isnt this closed with postgre;'s #4559 ?

@madelson
Copy link
Owner Author

madelson commented Nov 5, 2023

@M4urici0GM seems like it is, so this issue can be addressed in the next release of the postgres DistributedLock lib.

@Bartleby2718
Copy link
Contributor

Bartleby2718 commented Feb 25, 2024 •
edited
Loading

@madelson Given the latest comment, I think we'll need a major version bump for npgsql.

The breaking changes introduced in npgsql major version 6 don't seem to affect this library, but will this affect consumers?

@madelson
Copy link
Owner Author

@Bartleby2718 I agree; I think we'd go all the way to 8.x.

@Bartleby2718 Bartleby2718 mentioned this issue Mar 20, 2024
Merged
@madelson madelson added this to the 2.4 milestone Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bartleby2718 Bartleby2718

Labels
cleanup Code cleanup and other maintenance changes that do not affect runtime behavior
Projects
None yet
Milestone
2.4
Development

No branches or pull requests
3 participants
@madelson @Bartleby2718 @M4urici0GM