Feature : Allow resizing of files before downloading #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the gem dependencies. Update bundler and rake.
Allow resizing of zipped files before downloading.
According to the documentation, `service_url` shouldn't be used directly. Replace the call to `service_url` with `url_for`.
Sending the `url_for` method isn't supported by all services.
madeindjs
requested changes
Jul 26, 2020
There was a problem hiding this comment.
This PR sounds greats, thank you very much. Could you just :
- take a look of small remarks
- increase version number (lib/active_storage/send_zip/version.rb) so I will be able to publish new version
- you may want to add your name in Gemspec :) .
Comment on lines
14
to
16
| # @param files [ActiveStorage::Attached::One|ActiveStorage::Attached::Many|Array|Hash] file(s) to save | ||
| # @return [String] folder path of saved files | ||
| def self.save_files_on_server(files) | ||
| def self.save_files_on_server(files, resize_to_limit: nil) |
There was a problem hiding this comment.
Can you add documentation about this params
# @param [Boolean] Allow resizing of files before downloadingThere was a problem hiding this comment.
@madeindjs hi! Yes, I will make the requested changes.
Comment on lines
88
to
89
| # read file from service | ||
| # contents = URI.open(file.service.send(:url_for, file.key)) { |f| f.read } |
There was a problem hiding this comment.
Could you remove dead code ?
Suggested change
| # read file from service | |
| # contents = URI.open(file.service.send(:url_for, file.key)) { |f| f.read } |
Update the `CHANGELOG.yml` for version 0.3.4 with the resize feature.
Update the `README.md` with details on how to use the resize feature.
Increase the version number to 0.3.4. Add my name to the authors.
Document the `resize_to_limit` filter that can be applied to images before being zipped.
Add a test to ensure the behavior of resize_to_limit is working.
madeindjs
approved these changes
Jul 26, 2020
|
@biximilien , new version pushed https://rubygems.org/gems/active_storage-send_zip/versions/0.3.4 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had needed to resize the zipped files to specific formats before downloading them.
This might be useful to someone else.