Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: switch from aws-managed nodegroups to self-managed #277

Merged
merged 1 commit into from
May 2, 2022
Merged

refactor: switch from aws-managed nodegroups to self-managed #277

merged 1 commit into from
May 2, 2022

Conversation

mglotov
Copy link
Contributor

@mglotov mglotov commented May 2, 2022

PR Description

Switched from aws-managed nodegroups to self-managed nodegroups to mitigate next issues:

Fixes #275
Fixes #263

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@mglotov mglotov requested review from p1gmale0n, halfb00t, khalezin and a team May 2, 2022 05:54
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mglotov mglotov enabled auto-merge (squash) May 2, 2022 06:09
@mglotov mglotov disabled auto-merge May 2, 2022 07:56
@mglotov mglotov merged commit 3beda57 into main May 2, 2022
@mglotov mglotov deleted the refactor/self-managed-nodepools branch May 2, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p1gmale0n p1gmale0n p1gmale0n approved these changes

@khalezin khalezin khalezin approved these changes

@halfb00t halfb00t Awaiting requested review from halfb00t

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mglotov @p1gmale0n @khalezin