Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: switch from kubernetes-external-secrets to External Secrets Operator #276

Merged
merged 2 commits into from
Apr 28, 2022
Merged

refactor: switch from kubernetes-external-secrets to External Secrets Operator #276

merged 2 commits into from
Apr 28, 2022

Conversation

mglotov
Copy link
Contributor

@mglotov mglotov commented Apr 27, 2022 •
edited
Loading

PR Description

  • changed kubernetes-external-secrets to External Secrets Operator

How to use operator (for example with SecretsManager) can be found here.

Disabled global CRDs. So, we need to create SecretStore and ExternalSecret objects in necessary namespaces or enable them if it's needed.

Fixes #269

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@mglotov mglotov requested review from halfb00t, khalezin, p1gmale0n and a team April 27, 2022 08:21
@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mglotov mglotov enabled auto-merge (squash) April 27, 2022 08:49
@mglotov mglotov merged commit ccd8e98 into main Apr 28, 2022
@mglotov mglotov deleted the refactor/external-secrets branch April 28, 2022 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p1gmale0n p1gmale0n p1gmale0n approved these changes

@halfb00t halfb00t halfb00t approved these changes

@khalezin khalezin Awaiting requested review from khalezin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: kubernetes-external-secrets helm chart is deprecated
3 participants
@mglotov @p1gmale0n @halfb00t