Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Update documentation related to secrets #217

Merged
merged 4 commits into from
Nov 19, 2021
Merged

doc: Update documentation related to secrets #217

merged 4 commits into from
Nov 19, 2021

Conversation

mglotov
Copy link
Contributor

@mglotov mglotov commented Nov 19, 2021

PR Description

  • Updated documentation related to secrets
  • Added in FAQ.md some useful information about gitlab-runner and alertmanager
  • Fixed alertmanager installation

Fixes #216

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@sonarcloud
Copy link

sonarcloud bot commented Nov 19, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mglotov mglotov requested review from p1gmale0n and a team November 19, 2021 07:19
@mglotov mglotov merged commit a8ea83a into main Nov 19, 2021
@halfb00t halfb00t deleted the doc/variables_from_secrets branch November 23, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p1gmale0n p1gmale0n p1gmale0n approved these changes

@halfb00t halfb00t halfb00t approved these changes

@khalezin khalezin Awaiting requested review from khalezin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: Update documentation related to secrets
3 participants
@mglotov @p1gmale0n @halfb00t