Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh: use basic auth for Grafana by default and feature flag to switch between basic auth, github oauth and gitlab oauth #215

Merged
merged 3 commits into from
Nov 19, 2021
Merged

enh: use basic auth for Grafana by default and feature flag to switch between basic auth, github oauth and gitlab oauth #215

merged 3 commits into from
Nov 19, 2021

Conversation

mglotov
Copy link
Contributor

@mglotov mglotov commented Nov 18, 2021

PR Description

  • Added possibility to switch between basic auth, github oauth and gitlab oauth for Grafana.
  • Added notes in FAQ on how to do it.

Fixes #8

Type of change

  • New feature (non-breaking change which adds functionality)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@mglotov mglotov requested review from halfb00t, khalezin, p1gmale0n and a team November 18, 2021 09:29
@sonarcloud
Copy link

sonarcloud bot commented Nov 18, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mglotov mglotov merged commit ac2b6b7 into main Nov 19, 2021
@halfb00t halfb00t deleted the enh/grafana-oauth branch November 23, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p1gmale0n p1gmale0n p1gmale0n approved these changes

@halfb00t halfb00t halfb00t approved these changes

@khalezin khalezin Awaiting requested review from khalezin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Oauth for kibana and grafana from gitlab to github
3 participants
@mglotov @p1gmale0n @halfb00t