Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: do not use templates/nginx-ingress-values.yaml and set necessary values in the eks-ingress-nginx-controller.tf file #206

Merged
merged 4 commits into from
Nov 17, 2021
Merged

refactor: do not use templates/nginx-ingress-values.yaml and set necessary values in the eks-ingress-nginx-controller.tf file #206

merged 4 commits into from
Nov 17, 2021

Conversation

mglotov
Copy link
Contributor

@mglotov mglotov commented Nov 17, 2021 •
edited
Loading

PR Description

  • Moved values of the ingress-nginx-controller helm release from templates/nginx-ingress-values.yaml into the eks-ingress-nginx-controller.tf file as local variable.
  • Deleted unnecessary variable aws_loadbalancer_controller_enable

Fixes #205

Type of change

  • Code refactoring

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@mglotov
refactor: do not use templates/nginx-ingress-values.yaml and set nece…
072835a 
…ssary values in the eks-ingress-nginx-controller.tf file
@mglotov mglotov requested review from khalezin, halfb00t, p1gmale0n and a team and removed request for khalezin November 17, 2021 10:15
@sonarcloud
Copy link

sonarcloud bot commented Nov 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mglotov mglotov merged commit ed165c2 into main Nov 17, 2021
@mglotov mglotov deleted the refactor/ingress-nginx-values branch November 18, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p1gmale0n p1gmale0n p1gmale0n approved these changes

@halfb00t halfb00t halfb00t approved these changes

@khalezin khalezin Awaiting requested review from khalezin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: ingress-nginx-controller helm release values
3 participants
@mglotov @p1gmale0n @halfb00t