Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: do not use templates/cluster-autoscaler-values.yaml and set necessary values in the eks-cluster-autoscaler.tf file #200

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

mglotov
Copy link
Contributor

@mglotov mglotov commented Nov 17, 2021

PR Description

Moved values of the cluster-autoscaler helm release from templates/cluster-autoscaler-values.yaml into the cluser-autoscaler.tf file as local variable.

Fixes #199

Type of change

  • Code refactoring

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

… necessary values in the eks-cluster-autoscaler.tf file
@sonarcloud
Copy link

sonarcloud bot commented Nov 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mglotov mglotov requested review from p1gmale0n and a team November 17, 2021 06:29
@mglotov mglotov merged commit 08f189a into main Nov 17, 2021
@mglotov mglotov deleted the refactor/cluster_autoscaler_values branch November 18, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: cluster-autoscaler helm release values
3 participants