Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: do not use templates for helm releases #155

Closed
3 tasks done
mglotov opened this issue Nov 4, 2021 · 0 comments
Closed
3 tasks done

refactor: do not use templates for helm releases #155

mglotov opened this issue Nov 4, 2021 · 0 comments

Comments

@mglotov
Copy link
Contributor

mglotov commented Nov 4, 2021

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Expected Behavior

Might it'd be better not to have templates and render values in locals

locals {
 release_values << <<VALUES
rbac:
  create: true
  serviceAccount:
    annotations:
      eks.amazonaws.com/role-arn: ${module.aws_iam_autoscaler.role_arn}
 VALUES
}

Current Behavior

There are lots of templates are used for helm releases. Most of them have only several strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant