Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: changes in PR and Issue templates, CONTRIBUTING.md #132

Merged
merged 3 commits into from
Oct 15, 2021
Merged

doc: changes in PR and Issue templates, CONTRIBUTING.md #132

merged 3 commits into from
Oct 15, 2021

Conversation

halfb00t
Copy link
Member

@halfb00t halfb00t commented Oct 14, 2021 •
edited
Loading

PR Description

Changes:

  • moved code conventions from README.md to CONTRIBUTING.md
  • added TOC
  • Reviewed and edit PR and Issue Tempaltes

Fixes #131

Type of change

  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@halfb00t halfb00t requested review from p1gmale0n, mglotov, khalezin and a team October 14, 2021 14:09
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@halfb00t halfb00t changed the title Imp/contributing improvement: changes in PR and Issue templates, CONTRIBUTING.md Oct 14, 2021
@halfb00t halfb00t enabled auto-merge (squash) October 14, 2021 14:15
@mglotov
Copy link
Contributor

mglotov commented Oct 15, 2021

From my point of view, we need to use prefix doc here instead of using improvement

mglotov
mglotov reviewed Oct 15, 2021
View reviewed changes
.github/ISSUE_TEMPLATE.md Show resolved Hide resolved
.github/ISSUE_TEMPLATE.md Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@halfb00t halfb00t changed the title improvement: changes in PR and Issue templates, CONTRIBUTING.md doc: changes in PR and Issue templates, CONTRIBUTING.md Oct 15, 2021
@halfb00t halfb00t merged commit 82e9a0c into main Oct 15, 2021
@halfb00t halfb00t deleted the imp/contributing branch October 19, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatyana12345 tatyana12345 tatyana12345 approved these changes

@mglotov mglotov mglotov approved these changes

@and-babkin and-babkin and-babkin approved these changes

@p1gmale0n p1gmale0n Awaiting requested review from p1gmale0n

@khalezin khalezin Awaiting requested review from khalezin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring for PR and Issue templates, CONTRIBUTING.md
4 participants
@halfb00t @mglotov @tatyana12345 @and-babkin