Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Madara fails to sync block 20732 because of Legacy contract deserialization #396

Open
1 task done
notlesh opened this issue Nov 23, 2024 · 1 comment
Open
1 task done

Comments

@notlesh
Copy link
Contributor

notlesh commented Nov 23, 2024

Is there an existing issue?

  • I have searched the existing issues

Description of bug

While trying to sync mainnet with Madara, I found that sync fails on block 20732 when it attempts to request class 0x371b5f7c5517d84205365a87f02dcef230efa7b4dd91a9e4ba7e04c5b69d69b.

Error (not very helpful):

The provider has returned an error: Error serializing request: invalid type: null, expected a sequence, retrying in 6s

Specifically, it fails when trying to convert to a LegacyContractClass via serde_json::from_value here.

If we print the value it's attempting to use, we see that it has a null for abi:

{"abi":null,"entry_points_by_type":{"CONSTRUCTOR" ...

Which I'm guessing is why it fails.

Steps to reproduce

Sync mainnet with Madara up to block 20732, e.g.:

cargo run --release \
    -- \
    --name Madara \
    --full \
    --base-path "../somewhere" \
    --network mainnet \
    --l1-endpoint "<redacted>"
@notlesh notlesh changed the title Madara fails to sync block 20732 because of Legacy contract deserialization bug: Madara fails to sync block 20732 because of Legacy contract deserialization Nov 23, 2024
@antiyro
Copy link
Member

antiyro commented Nov 25, 2024

This PR should solve it #394. Tell me if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants