-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mrustc: update to 20221110 #16284
mrustc: update to 20221110 #16284
Conversation
@catap Why is it blocked by upstream though? arm64 is only going to get bigger. Intel is a thing of the past. |
@barracuda156 it requires unmerged patches to upstream :) |
This has been sitting around for quite a while... |
@pmetzger I'm waiting for upstream to react to the thepowersgang/mrustc#292 This is a bit tricky and can broke something => I prefer to keep it as draft until it is reviewed and merged by upstream. |
@pmetzger upstream is merged all required patches. I've worked very hard to bring To best of my knowledge it is as good as it can be and ready to merge. |
@catap So arch hardcoding is gone? We can try PPC? |
@barracuda156 I've replaced the hardcoded place to support arm64 :) Anyway, PPC requires future patches, at least it should be defined here: https://github.com/thepowersgang/mrustc/blob/b4556a7bb4519831e03d3a95448e0881923a16e0/src/trans/target.cpp#L570-L595 and it requires to define
So, short summary:
Anyway, I suggest to wait with |
@reneeotten I'm a maintainer of this port. May I ask you to merge this PR? Thanks. |
Thanks Ken! |
@catap I get this: Failed to parse file lang/mrustc/Portfile: can't read "rust_platforms()": no such element in array |
@barracuda156 seems that you've tried it on unsupported (yet) platforms => if so, feel free to add your platform to this list. I really doubt that PPC works. But i386 might. You may ass |
Well, parsing the portfile should work on all platforms, I guess? I am aware that building for PPC is not [yet] supported. |
@barracuda156 indeed. |
@catap Just for the record, it still fails trying to build an x86 component:
|
@barracuda156 seems that cross compilation doesn't detects the CPU features right :( |
Description
Here the initial support of arm64.
Type(s)
Tested on
macOS 12.6 21G115 arm64
Xcode 13.1 13A1030d
macOS 12.6 21G115 x86_64
Xcode 14.0.1 14A400
Verification
Have you
port lint --nitpick
?sudo port -vst install
?