Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrcpy: Move libusb dependency from build to lib #14838

Merged
merged 1 commit into from
May 13, 2022
Merged

scrcpy: Move libusb dependency from build to lib #14838

merged 1 commit into from
May 13, 2022

Conversation

neverpanic
Copy link
Member

Description

The scrcpy binary links against libusb, so it should be available at
runtime:

$> otool -L /opt/local/bin/scrcpy | grep libusb
  /opt/local/lib/libusb-1.0.0.dylib (compatibility version 4.0.0, current version 4.0.0)
$> port provides /opt/local/lib/libusb-1.0.0.dylib
/opt/local/lib/libusb-1.0.0.dylib is provided by: libusb

See Genymobile/scrcpy#2256 (comment).

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 11.6.5 20G527 x86_64
Xcode 13.2.1 13C100

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@neverpanic
scrcpy: Move libusb dependency from build to lib
e6d2ec8 
The scrcpy binary links against libusb, so it should be available at
runtime:

| $> otool -L /opt/local/bin/scrcpy | grep libusb
|   /opt/local/lib/libusb-1.0.0.dylib (compatibility version 4.0.0, current version 4.0.0)
| $> port provides /opt/local/lib/libusb-1.0.0.dylib
| /opt/local/lib/libusb-1.0.0.dylib is provided by: libusb

See Genymobile/scrcpy#2256 (comment).
@macportsbot
Copy link

Notifying maintainers:
@MarcelBochtler for port scrcpy.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: bugfix labels May 13, 2022
@neverpanic neverpanic merged commit 1ee4853 into macports:master May 13, 2022
@neverpanic neverpanic deleted the cal-scrcpy-missing-libusb-dep branch May 13, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelBochtler MarcelBochtler MarcelBochtler approved these changes

Assignees
No one assigned
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: bugfix
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neverpanic @macportsbot @MarcelBochtler