🐛 Cursors use SystemMouseCursors.click instead of SystemMouseCursors.basic

[wilsonowilson]

Description

Clickable macOS components do not use the "click cursor". They have always used the default cursor. This forms a distinction between using the web on macOS and interacting with macOS applications.

So by default, clickable elements in macos_ui should use SystemMouseCursors.basic instead of SystemMouseCursors.click. I also believe an option should be provided to customize that.

[bdlukaa]

You can wrap the widget you want in a MouseRegion to add a mouse cursor.

MouseRegion(
  cursor: SystemMouseCursos.click,
  child: Checkbox(...),
),

[wilsonowilson]

Yes I'm aware of that, but that's not what I'm talking about.

This is a snippet from back_button.dart.

MouseRegion(
      cursor: SystemMouseCursors.click,
      child: GestureDetector(
        behavior: HitTestBehavior.opaque,

I'm saying that the in-built widgets shouldn't use SystemMouseCursors.click by default.

[bdlukaa]

Will be fixed alongside #142

[wilsonowilson]

The pull request doesn't address what I'm talking about. @GroovinChip might explain better.

[GroovinChip]

Wasn't it that mouse cursors should never be pointers? Material State Props can help us ensure that, right? Along with making it customizable?

[wilsonowilson]

It can ensure customisation yes, but it doesn't directly relate to the issue. I can open a separate PR once #142 is merged.

And I'm not sure we'd want to use MacosStateProperty on cursors. I haven't seen that usage even in the material buttons.

[GroovinChip]

Fair enough

[bdlukaa]

I have some ideas for this. We can have a MouseCursor property in the MacosThemeData class, and all the inputs will use it.

By default, on macOS and iOS, the cursor used will be MouseCursor.defer. On the other platforms, SystemMouseCursors.click shall be used. Something like:

MouseCursor _defaultMouseCursor() {
  switch (defaultTargetPlatform) {
    case TargetPlatform.macOS:
    case TargetPlatform.iOS:
      return MouseCursor.defer;
    default:
      return SystemMouseCursors.click;
  }
}

[wilsonowilson]

That sounds great!

[GroovinChip]

@wilsonowilson so to recap: we're saying that all mouse cursors should default to something like MouseCursor.defer, correct?

[wilsonowilson]

@GroovinChip Yeah, although I'm not sure if we'd want to use MouseCursor.defer over SystemMouseCursors.basic because it defers the cursor handling to its children.