Skip to content
This repository has been archived by the owner on Nov 14, 2017. It is now read-only.

ADPM showed days until expiry as a negative number #27

Closed
steven-j-klein opened this issue Nov 19, 2015 · 5 comments
Closed

ADPM showed days until expiry as a negative number #27

steven-j-klein opened this issue Nov 19, 2015 · 5 comments
Assignees
Labels
Milestone

Comments

@steven-j-klein
Copy link

Today when I unlocked my Mac, I looked in my menu bar and was surprised to see that my password would expire in [-58d]. That's actually when I last changed my password — 58 days ago.

I selected Re-check Expiration and it changed to [31d] which is the correct number.

@macmule
Copy link
Owner

macmule commented Nov 19, 2015

Hi Steven,

I think this is related to something I'm to add :)

I'll try & resolve over the week.

@macmule macmule self-assigned this Nov 19, 2015
@macmule macmule added the bug label Nov 19, 2015
@steven-j-klein
Copy link
Author

BTW, is it my imagination, or did the days used to be reported in brackets? Like this: [31d]

Because I just noticed that it's appearing without brackets in my menubar: 31d

(FWIW, I prefer no brackets.)

@pmbuko
Copy link
Collaborator

pmbuko commented Nov 19, 2015

This is true. We did away with the brackets in one of the most recent releases.

On Nov 19, 2015, at 6:27 AM, steven-j-klein [email protected] wrote:

BTW, is it my imagination, or did the days used to be reported in brackets? Like this: [31d]

Because I just noticed that it's appearing without brackets in my menubar: 31d

(FWIW, I prefer no brackets.)


Reply to this email directly or view it on GitHub.

@macmule macmule modified the milestone: 2.20.1 Nov 21, 2015
@macmule
Copy link
Owner

macmule commented Nov 23, 2015

I'm guessing this is the same issue I have seen.

ADPM was not re-checking expiration post launch if on launch the domain was not reachable.

Changed the startmeup, passexpires & moved domaintest to intervaldomaintest with the login from the startmeup function being moved to those last 2 functions.

End result? ADPM should now check for password on an interval & will update expiration etc when back on the domain.

This is in the pre-release (https://github.com/macmule/ADPassMon/releases/tag/122), awaiting review before merging.

@macmule
Copy link
Owner

macmule commented Nov 23, 2015

Example log post changes:

23/11/2015 23:14:21.746 ADPassMon[60865]: Domain not reachable.
23/11/2015 23:19:21.958 ADPassMon[60865]: Domain reachable.
23/11/2015 23:19:21.959 ADPassMon[60865]: Testing if password can expire…
23/11/2015 23:19:22.369 ADPassMon[60865]: Password does expire.
23/11/2015 23:19:22.472 ADPassMon[60865]: Domain reachable.
23/11/2015 23:19:22.472 ADPassMon[60865]: Starting manual process…
23/11/2015 23:19:22.472 ADPassMon[60865]: Found expireDateUnix in plist: 1.449391035E+9
23/11/2015 23:19:22.570 ADPassMon[60865]: Got expireDateUnix: 1449391035
23/11/2015 23:19:22.570 ADPassMon[60865]: Using alt method
23/11/2015 23:19:22.662 ADPassMon[60865]: New pwdSetDate (16745.36)
23/11/2015 23:19:22.662 ADPassMon[60865]: ≥ plist value (1.674536E+4) so we use it
23/11/2015 23:19:22.672 ADPassMon[60865]: daysUntilExp: 12.38822
23/11/2015 23:19:22.673 ADPassMon[60865]: expirationDate: Sunday, 6 December 2015 08:38:24
23/11/2015 23:19:22.674 ADPassMon[60865]: ADPassMon password method selected
23/11/2015 23:19:22.674 ADPassMon[60865]: Testing Keychain Lock state...
23/11/2015 23:19:22.695 ADPassMon[60865]: Keychain unlocked...

@macmule macmule closed this as completed Nov 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants