Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropbox api and tmparchive script fail if the docx name contains endash #113

Open
mattretzer opened this issue Jul 13, 2017 · 2 comments
Open

Comments

@mattretzer
Copy link
Contributor

mattretzer commented Jul 13, 2017

I'm not sure we can do anything about the dropbox api not handling endashes, except maybe trap & handle/report the error (if we rename the file prior to the dropbox-api running, it renders the submitter info moot).
But it looks like something in the tmparchive script's file-rename-and-move is failing and crashing egalleymaker, and that we should be able to fix.
Problem file: https://www.dropbox.com/s/iw6yn300y2ehi53/Caddyshack_Final%20MS_06-29-17%E2%80%939781250105950.docx?dl=0

@mattretzer
Copy link
Contributor Author

For an un-handleable character like this, it would be good to give feedback in the folder (since we can't capture the submitter). I think we should be getting an api-failure anyways so can manually look up the submitter and email them as well regardless (provided we've handled tmparchive crash)

@mattretzer
Copy link
Contributor Author

This happened again with this file. It could also be an issue with endash encoding in python (as the filename is passed form ruby to python) and not dropbox at all, merits review. Because the convert_to_docx.py script is crashing too. Subsequent itms in temparchive.rb crash too, I think b/c they presume there will be a .docx file, and the file move out of the IN folder fails as a result too.

Anyways, we should look at this sooner rather than later, since it's basically failing silently.

Bumping this bug near top of the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant