Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks with Glimmerjs #295

Closed
rmzr7 opened this issue Apr 7, 2017 · 8 comments
Closed

Breaks with Glimmerjs #295

rmzr7 opened this issue Apr 7, 2017 · 8 comments
Milestone

Comments

@rmzr7
Copy link

rmzr7 commented Apr 7, 2017

Emblem only works with ember but not glimmer

@thec0keman
Copy link
Collaborator

That's a great point. GlimmerJS introduces a new syntax for components, and Emblem does not support this. There was some initial work on angle bracket components a year ago, but that was stopped when it became clear Ember had not settled on a syntax.

I don't think it would take a lot to support the GlimmerJS syntax. Do we know if Ember is planning on using a similar syntax?

@auvipy
Copy link

auvipy commented May 8, 2017

ember will gradually adapt changes from glimmers eventually

@thec0keman
Copy link
Collaborator

CC @machty what do you think?

@thec0keman
Copy link
Collaborator

FWIW this RFC outlines some of the areas of convergence and divergence of Ember and Glimmer.

@machty
Copy link
Owner

machty commented Jun 26, 2017

Confirm, a lot of the details will be fleshed out in that RFC; I'd be happy to make the necessary Emblem changes as things solidify more :)

@thec0keman
Copy link
Collaborator

Sounds good! I'm willing to help out too, just been hesitant to start until the API is ready.

@thec0keman
Copy link
Collaborator

FYI on master this syntax should be working. Would be great to test and confirm

@thec0keman thec0keman added this to the v1.0.0 milestone Feb 14, 2018
@thec0keman
Copy link
Collaborator

I'm going to close this for now. The test suite has several examples of glimmer components. I'm not sure if we are 100% to full glimmer support, but if not we are close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants