Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in deployment prereq #294

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Fix broken link in deployment prereq #294

merged 2 commits into from
Feb 9, 2022

Conversation

rafvasq
Copy link
Contributor

@rafvasq rafvasq commented Feb 8, 2022

Updates Openshift link in Kubernetes cluster deployment prerequisites.

Resolves #293

Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rafvasq for finding and fixing the broken link and curl command.

I just have a small nit-pick :-)

docs/mlx-setup.md Outdated Show resolved Hide resolved
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rafael. Sorry, I did not look at your second change carefully earlier.

* [`kustomize v3.2.0`](https://github.com/kubernetes-sigs/kustomize/releases/tag/v3.2.0) is installed
* Kustomize v3.2.0 quick install:
```
OS=$(uname)
curl -L https://github.com/kubernetes-sigs/kustomize/releases/download/v3.2.0/kustomize_3.2.0_${OS}_amd64 --output kustomize
curl -L https://github.com/kubernetes-sigs/kustomize/releases/download/v3.2.0/kustomize_3.2.0_{$OS}_amd64 --output kustomize
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second look, I don't think this change is right, even though curl seems to work with either command variation.

https://stackoverflow.com/questions/4181703/how-to-concatenate-string-variables-in-bash/4181721#4181721

This form _{$OS}_ prints the URL with braces "_{Darwin}_":

$ echo "https://github.com/kubernetes-sigs/kustomize/releases/download/v3.2.0/kustomize_3.2.0_{$OS}_amd64"

https://github.com/kubernetes-sigs/kustomize/releases/download/v3.2.0/kustomize_3.2.0_{Darwin}_amd64

The original format (_${OS}_) prints the URL correctly ( "_Darwin_" without braces):

$ echo "https://github.com/kubernetes-sigs/kustomize/releases/download/v3.2.0/kustomize_3.2.0_${OS}_amd64"

https://github.com/kubernetes-sigs/kustomize/releases/download/v3.2.0/kustomize_3.2.0_Darwin_amd64

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into it. I was having issues with the original curl command and now realize that it wasn't working for me because I'm using oh-my-zsh, which escapes characters with backslash when I paste a URL.

@rafvasq rafvasq changed the title Fix link and curl cmd Fix Kubernetes link Feb 9, 2022
Rafael Vasquez added 2 commits February 8, 2022 22:29
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq rafvasq changed the title Fix Kubernetes link Fix broken link in deployment prereq Feb 9, 2022
@rafvasq rafvasq requested a review from ckadner February 9, 2022 03:31
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks Rafael

@mlx-bot
Copy link
Collaborator

mlx-bot commented Feb 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner merged commit c24c2ed into machine-learning-exchange:main Feb 9, 2022
@ckadner
Copy link
Member

ckadner commented Feb 9, 2022

/assign @rafvasq

@ckadner ckadner added the Jump-Start Work items for Jump-Start participants label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Jump-Start Work items for Jump-Start participants lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link and curl cmd in Kubernetes deployment prerequisites
3 participants