-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken link in deployment prereq #294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rafvasq for finding and fixing the broken link and curl command.
I just have a small nit-pick :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Rafael. Sorry, I did not look at your second change carefully earlier.
docs/mlx-setup.md
Outdated
* [`kustomize v3.2.0`](https://github.com/kubernetes-sigs/kustomize/releases/tag/v3.2.0) is installed | ||
* Kustomize v3.2.0 quick install: | ||
``` | ||
OS=$(uname) | ||
curl -L https://github.com/kubernetes-sigs/kustomize/releases/download/v3.2.0/kustomize_3.2.0_${OS}_amd64 --output kustomize | ||
curl -L https://github.com/kubernetes-sigs/kustomize/releases/download/v3.2.0/kustomize_3.2.0_{$OS}_amd64 --output kustomize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second look, I don't think this change is right, even though curl
seems to work with either command variation.
This form _{$OS}_
prints the URL with braces "_{Darwin}_
":
$ echo "https://github.com/kubernetes-sigs/kustomize/releases/download/v3.2.0/kustomize_3.2.0_{$OS}_amd64"
https://github.com/kubernetes-sigs/kustomize/releases/download/v3.2.0/kustomize_3.2.0_{Darwin}_amd64
The original format (_${OS}_
) prints the URL correctly ( "_Darwin_
" without braces):
$ echo "https://github.com/kubernetes-sigs/kustomize/releases/download/v3.2.0/kustomize_3.2.0_${OS}_amd64"
https://github.com/kubernetes-sigs/kustomize/releases/download/v3.2.0/kustomize_3.2.0_Darwin_amd64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into it. I was having issues with the original curl command and now realize that it wasn't working for me because I'm using oh-my-zsh
, which escapes characters with backslash when I paste a URL.
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks Rafael
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, rafvasq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @rafvasq |
Updates Openshift link in Kubernetes cluster deployment prerequisites.
Resolves #293