Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform specification for ARM/M1 compatability with mysql #272

Conversation

BluThaitanium
Copy link
Contributor

Adds docker compatibility for ARM architecture including M1 chips

@BluThaitanium
Copy link
Contributor Author

BluThaitanium commented Dec 1, 2021

Tested and works on M1 MacOS & Ubuntu Linux @ckadner

@BluThaitanium BluThaitanium force-pushed the mysql_arm_m1_compatability branch from 9484be8 to 060bf2e Compare December 1, 2021 20:43
@ckadner ckadner added the RCOS Potential work items for RCOS student interns label Dec 1, 2021
@ckadner ckadner requested review from ckadner and Zachary-Fernandes and removed request for animeshsingh and Tomcli December 2, 2021 00:08
@ckadner
Copy link
Member

ckadner commented Dec 2, 2021

Thanks Phu!

Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@mlx-bot
Copy link
Collaborator

mlx-bot commented Dec 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BluThaitanium, ckadner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner
Copy link
Member

ckadner commented Dec 2, 2021

@Zachary-Fernandes -- if you can confirm this works on Windows/WSL as well, please add your /lgtm. Thanks

@Zachary-Fernandes
Copy link
Contributor

This works for me on Powershell and WSL2. I think it is ready to go.

/lgtm

@mlx-bot mlx-bot added the lgtm label Dec 2, 2021
@mlx-bot mlx-bot merged commit 10d75a9 into machine-learning-exchange:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm RCOS Potential work items for RCOS student interns
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants