Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI needs to implement a logout page/button/route #78

Open
Tomcli opened this issue Jun 4, 2021 · 5 comments
Open

UI needs to implement a logout page/button/route #78

Tomcli opened this issue Jun 4, 2021 · 5 comments
Labels
RCOS Potential work items for RCOS student interns size/L UI User Interface

Comments

@Tomcli
Copy link
Member

Tomcli commented Jun 4, 2021

Is your feature request related to a problem? Please describe.
Right now there's no way for the admin to logout other than clear up the browser cookies, so we need a logout page to simply this process.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@ckadner ckadner added RCOS Potential work items for RCOS student interns size/L labels Sep 21, 2021
@ckadner ckadner added the UI User Interface label Sep 30, 2021
@ckadner ckadner changed the title [ui] UI needs to implement a logout page UI needs to implement a logout page Sep 30, 2021
@ckadner
Copy link
Member

ckadner commented Oct 14, 2021

I don't think we need a new page. Just a logout button should suffice.

An even quicker fix could be to just implement a "Route" instead of a whole page. Meaning, if a logged-in admin user appends "/logout" to the MLX UI's base URL in the browser's address bar, i.e. https://ml-exchange.org/logout (similar to the login URL: https://ml-exchange.org/login)

@ckadner
Copy link
Member

ckadner commented Oct 14, 2021

@Zachary-Fernandes -- See #41 for information about how the /login was implemented

@ckadner
Copy link
Member

ckadner commented Oct 14, 2021

@yhwang -- could you provide some guidance, as to how a logout function should be implemented? ... removing session cookies, userInfo, etc. Thanks!

@yhwang
Copy link
Member

yhwang commented Oct 15, 2021

@ckadner yes, a route to handle /logout should be enough. but we also need to handle the /logout on the server side to remove the session.

@Prasantacharya
Copy link
Contributor

I can also work on this issue as well if zack hasn’t started on it, or needs some help

@ckadner ckadner assigned Prasantacharya and unassigned yhwang Oct 19, 2021
@ckadner ckadner changed the title UI needs to implement a logout page UI needs to implement a logout page/button/route Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RCOS Potential work items for RCOS student interns size/L UI User Interface
Projects
None yet
Development

No branches or pull requests

4 participants