Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catalog upload API should allow all uploaded assets to be published and featured #237

Closed
ckadner opened this issue Oct 16, 2021 · 1 comment · Fixed by #256
Closed

Catalog upload API should allow all uploaded assets to be published and featured #237

ckadner opened this issue Oct 16, 2021 · 1 comment · Fixed by #256
Assignees
@ckadner @drewbutlerbb4

Comments

@ckadner
Copy link
Member

ckadner commented Oct 16, 2021

Add parameters to the /catalog upload API to automatically set the uploaded assets to be featured and publish_approved.
@ckadner
Copy link
Member Author

ckadner commented Oct 16, 2021

@drewbutlerbb4 -- when the UI does the catalog upload, there is a progress bar that seems to indicate the catalog_upload.json file content is broken down into individual asset uploads? If so, would it be easy to also call the publish_approved and featured API endpoints from the UI?

ckadner added a commit to ckadner/mlx that referenced this issue Nov 8, 2021
@ckadner
Feature all assets from catalog upload
7fa7e17 
This removes the need to toggle both the Published and
Featured checkboxes for each of the (46) uploaded assets.

Since uploading a curated catalog can only be done by admins,
we assume that all the uploaded assets are to be published
and featured.

Resolves machine-learning-exchange#237

Signed-off-by: Christian Kadner <[email protected]>
@ckadner ckadner mentioned this issue Nov 8, 2021
Merged
mlx-bot pushed a commit that referenced this issue Nov 9, 2021
@ckadner
Feature all assets from catalog upload (#256)
aca026e 
This removes the need to toggle both the Published and
Featured checkboxes for each of the (46) uploaded assets.

Since uploading a curated catalog can only be done by admins,
we assume that all the uploaded assets are to be published
and featured.

Resolves #237

Signed-off-by: Christian Kadner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckadner ckadner

@drewbutlerbb4 drewbutlerbb4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature all assets from catalog upload ckadner/mlx
2 participants
@ckadner @drewbutlerbb4