Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework bootstrapper #23

Open
ckadner opened this issue May 6, 2021 · 4 comments
Open

Rework bootstrapper #23

ckadner opened this issue May 6, 2021 · 4 comments
Assignees
Labels
question Further information is requested RCOS Potential work items for RCOS student interns size/S

Comments

@ckadner
Copy link
Member

ckadner commented May 6, 2021

$ grep -o -h -E "http.*yaml" bootstrapper/configmap.yaml | \
  while read url; do \
    curl -s -o /dev/null -w "%{http_code}" $url; echo ": ${url}"; \
  done | grep --color "404"
404: https://raw.githubusercontent.com/machine-learning-exchange/katalog/main/model-samples/max-audio-classifier.yaml
404: https://raw.githubusercontent.com/machine-learning-exchange/katalog/main/model-samples/max-breast-cancer-mitosis-detector.yaml
404: https://raw.githubusercontent.com/machine-learning-exchange/katalog/main/model-samples/max-facial-age-estimator.yaml
404: https://raw.githubusercontent.com/machine-learning-exchange/katalog/main/model-samples/max-image-segmenter.yaml
404: https://raw.githubusercontent.com/machine-learning-exchange/katalog/main/model-samples/max-news-text-generator.yaml
404: https://raw.githubusercontent.com/machine-learning-exchange/katalog/main/model-samples/max-sports-video-classifier.yaml
@ckadner ckadner changed the title Missing MAX models? Can bootstrapper/configmap.yaml be removed? It's pointing to missing MAX model YAML files May 6, 2021
@ckadner ckadner added the question Further information is requested label May 6, 2021
@Tomcli
Copy link
Member

Tomcli commented May 6, 2021

@ckadner Since we already have the API to populate the initial catalogs, can we move the bootstrapper init functions to the API so we don't have to maintain another configmap?

@ckadner
Copy link
Member Author

ckadner commented May 6, 2021

We could just keep the bootstrapper/catalog_upload.json and add a small Python script to call the API.

I would then remove all of these files:

  • bootstrapper/bootstrap.yaml
  • bootstrapper/configmap.yaml
  • bootstrapper/Dockerfile
  • bootstrapper/start.py

And rewrite the README.md

If you agree I will create a PR for that.

@Tomcli
Copy link
Member

Tomcli commented May 6, 2021

sure

@ckadner ckadner assigned ckadner and unassigned Tomcli May 6, 2021
@ckadner ckadner changed the title Can bootstrapper/configmap.yaml be removed? It's pointing to missing MAX model YAML files Rework bootstrapper Sep 15, 2021
@ckadner ckadner added RCOS Potential work items for RCOS student interns size/S labels Sep 21, 2021
@GiriSrini
Copy link

@ckadner I would like to work on this issue.

@ckadner ckadner assigned GiriSrini and unassigned ckadner Oct 14, 2021
@ckadner ckadner linked a pull request Dec 2, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested RCOS Potential work items for RCOS student interns size/S
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants