-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Unpublished assets should not be accessible anonymously #207
Comments
@ckadner I would like to work on this issue. |
Check for mlx/dashboard/origin-mlx/src/App.tsx Line 61 in 2d5ca37
|
@Zachary-Fernandes -- Since we do not yet have a logout functionality #78 you would need to bring up the MLX UI in a private browser window to see the un-cached results for an anonymous user |
Zachary-Fernandes
added a commit
to Zachary-Fernandes/mlx
that referenced
this issue
Oct 27, 2021
Added if check to redirect users to a 404 page if the asset they attempt to access is unpublished and the user is anonymous. Resolves machine-learning-exchange#207 Signed-off-by: Zachary-Fernandes <[email protected]>
mlx-bot
pushed a commit
that referenced
this issue
Oct 27, 2021
* Ensure unpublished assets cannot be accessed anonymously Added if check to redirect users to a 404 page if the asset they attempt to access is unpublished and the user is anonymous. Resolves #207 Signed-off-by: Zachary-Fernandes <[email protected]> * Removed debug message Signed-off-by: Zachary-Fernandes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
After an admin unpublished an asset (unchecks the boxes for featured and published), the direct access link should no longer work for unauthenticated users (private browser, not logged in).
To Reproduce
Expected behavior
The text was updated successfully, but these errors were encountered: