Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URIs with invalid characters are not escaped #107

Open
machawk1 opened this issue Oct 22, 2018 · 1 comment
Open

URIs with invalid characters are not escaped #107

machawk1 opened this issue Oct 22, 2018 · 1 comment
Labels

Comments

@machawk1
Copy link
Owner

In some places on the web, invalid URIs may be used to identify resource representations. For example, at one point (perhaps still) Google Fonts recommended values like https://fonts.googleapis.com/css?family=Open+Sans:400,600,800,700|Open+Sans+Condensed:300.

The un-encoded pipe (|) here is invalid via RFC3986 (also see here) and I believe it may be WARCreate's responsibility to ensure this value is stored in WARCs in a manner that ensures interoperability.

$ jwattools test -e warc-in-question.warc will report these errors for invalid WARCs in the produced i.out file.

TODO: check validity of URIs, particularly in the WARC-Target-URI field, prior to association them with a preserved entity representation.

@machawk1 machawk1 added the bug label Oct 22, 2018
@machawk1
Copy link
Owner Author

See also google/fonts#1163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant