Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version_name is an invalid manifest key #100

Open
machawk1 opened this issue Jan 19, 2018 · 0 comments
Open

version_name is an invalid manifest key #100

machawk1 opened this issue Jan 19, 2018 · 0 comments

Comments

@machawk1
Copy link
Owner

machawk1 commented Jan 19, 2018

Based off of https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/management/ExtensionInfo, our usage of version_name in the manifest to distinguish builds, a change or removal of this attribute is needed to be compatible with WebExtensions.

Removal is not critical, as the field will likely be ignored. Firefox's more expressive version value would normally be a good replacement exception it is more expressive than Chrome allows for this field, so information like "build" is not allowed in the version string for Chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant