feat: Improve mParticle reset methods #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mparticle-automation
added a commit
that referenced
this pull request
Mar 19, 2024
# [8.21.0](v8.20.0...v8.21.0) (2024-03-19) ### Bug Fixes * Correct threading around user notification log ([#261](#261)) ([456160b](456160b)) * Refactor MPUploadBuilder to attempt to eliminate rare crash in withLocation: method ([#262](#262)) ([60cd0c8](60cd0c8)) ### Features * Improve mParticle reset methods ([#263](#263)) ([cde71a2](cde71a2))
|
🎉 This PR is included in version 8.21.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This looks big because of all the test cleanup, but the only real changes are in the
mParticle.m/hfiles and are minimalresetmethod to it's original implementation and mark it deprecatedreset:method to use async dispatch to prevent potential for deadlocksTesting Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)