Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Setup Logic for Tracking URL #248

Merged
merged 1 commit into from
Feb 7, 2024
Merged

feat: Setup Logic for Tracking URL #248

merged 1 commit into from
Feb 7, 2024

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

  • Add logic to route requests to the tracking- urls after a user accepts tracking (using ATT status), before accepting it should route to the current urls

Testing Plan

  • Tested normal function in sample app (using default URL) and updated unit tests

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Feb 2, 2024
@BrandonStalnaker BrandonStalnaker changed the base branch from development to feature/privacy-manifest February 7, 2024 14:48
einsteinx2
einsteinx2 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@einsteinx2 einsteinx2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I don't see any issues. Confirmed the approach on Zoom today with Sam. Thanks for updating the unit tests!

@BrandonStalnaker BrandonStalnaker merged commit 5894107 into feature/privacy-manifest Feb 7, 2024
11 checks passed
@BrandonStalnaker BrandonStalnaker deleted the feat/6060-Setup-Logic-For-Tracking-URL branch February 7, 2024 17:23
BrandonStalnaker added a commit that referenced this pull request Feb 21, 2024
@BrandonStalnaker
feat: Add Privacy Manifest and Tracking Domain Logic (#249)
533c37d 
* feat: Add Privacy Manifes
* feat: Setup Logic for Tracking URL (#248)
einsteinx2 pushed a commit that referenced this pull request Feb 22, 2024
@BrandonStalnaker @einsteinx2
feat: Add Privacy Manifest and Tracking Domain Logic (#249)
7e9c17d 
* feat: Add Privacy Manifes
* feat: Setup Logic for Tracking URL (#248)
einsteinx2 pushed a commit that referenced this pull request Feb 23, 2024
@BrandonStalnaker @einsteinx2
feat: Add Privacy Manifest and Tracking Domain Logic (#249)
d88acde 
* feat: Add Privacy Manifes
* feat: Setup Logic for Tracking URL (#248)
mparticle-automation added a commit that referenced this pull request Feb 23, 2024
@mparticle-automation
chore(release): 8.19.0 [skip ci]
d604e59 
# [8.19.0](v8.18.0...v8.19.0) (2024-02-23)

### Features

* Add Privacy Manifest and Tracking Domain Logic ([#249](#249)) ([d88acde](d88acde)), closes [#248](#248)
* Add privacy manifest to build artifacts ([#255](#255)) ([aaeb8e4](aaeb8e4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einsteinx2 einsteinx2 einsteinx2 approved these changes

Assignees

@BrandonStalnaker BrandonStalnaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrandonStalnaker @einsteinx2