Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove Disk Space API Usage #221

Merged

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

  • Remove CurrentState entirely as part of removing all uses of the Disk Space API

Testing Plan

  • Tested locally and end to end with the Livestream. One of the main code paths were this data was being included is when logging identity changes so I confirmed these events along with a broad range of others still ends up on the live stream correctly.
Screenshot 2023-08-30 at 10 14 19 AM Screenshot 2023-08-30 at 10 14 07 AM

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BrandonStalnaker BrandonStalnaker merged commit 8bdf935 into development Sep 1, 2023
15 checks passed
@BrandonStalnaker BrandonStalnaker deleted the feat/SQDSDKS-5547-Remove-Disk-Space-API-use branch September 1, 2023 15:32
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mparticle-automation added a commit that referenced this pull request Sep 7, 2023
# [8.15.0](v8.14.2...v8.15.0) (2023-09-07)

### Features

* Remove Disk Space API Usage ([#221](#221)) ([8bdf935](8bdf935))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants