Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:Push Registration events to show forwarded for kits #208

Merged
merged 1 commit into from
Oct 2, 2023
Merged

fix:Push Registration events to show forwarded for kits #208

merged 1 commit into from
Oct 2, 2023

Conversation

mmustafa-tse
Copy link
Contributor

@mmustafa-tse mmustafa-tse commented Jul 19, 2023 •
edited
Loading

Summary

  • It was reported by one of our clients that push registration events were showing as 0 for Braze even though it was incrementing for the inbound count in the event forwarding view even though it was working as expected. After further investigation, I've noticed in our code that when we forward the call to the kits, its being passed as MPMessageTypeUnknown in stead of MPMessageTypePushRegistration which then is dropped since the if statement in kitContainer at line 2341 drops any event with MPMessageTypeUnknown

Testing Plan

  • [Y] Was this tested locally? If not, explain why.
  • E2E testing

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

BrandonStalnaker
BrandonStalnaker approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested alongside other push notification changes

@BrandonStalnaker BrandonStalnaker merged commit c3f1883 into mParticle:development Oct 2, 2023
BrandonStalnaker pushed a commit that referenced this pull request Oct 4, 2023
@mmustafa-tse @BrandonStalnaker
fix: Push Registration events to show forwarded for kits (#208)
705e568
mparticle-automation added a commit that referenced this pull request Oct 4, 2023
@mparticle-automation
chore(release): 8.15.1 [skip ci]
ce61b65 
## [8.15.1](v8.15.0...v8.15.1) (2023-10-04)

### Bug Fixes

* Push Registration events to show forwarded for kits ([#208](#208)) ([705e568](705e568))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

@einsteinx2 einsteinx2 Awaiting requested review from einsteinx2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmustafa-tse @BrandonStalnaker