fix: update active kits header #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field was previously sending a list of kits that were activley receiving events. Now it will send a list of kits that have been configured, even if they are not activley receiving events due to the SDK state. For Example, a kit that was shut down due to the current user's logged-in status not matching its configurations directive previous would not have been included in this list but now will be included
willpassidomo
changed the title
einsteinx2
previously requested changes
Apr 27, 2022
- configuredKitsRegistry nullability - dot syntax over brackets
|
@einsteinx2 all updated now :) let me know how it looks |
einsteinx2
previously requested changes
Apr 29, 2022
einsteinx2
previously requested changes
May 5, 2022
|
@einsteinx2 bump :) |
einsteinx2
approved these changes
May 12, 2022
einsteinx2
pushed a commit
that referenced
this pull request
May 16, 2022
The `x-mp-kits` header field was previously sending a list of kits that were actively receiving events. Now it will send a list of kits that have been configured, even if they are not actively receiving events due to the SDK state. For example, a kit that was shut down due to the current user's logged-in status not matching its configurations directive previous would not have been included in this list, but now will be included.
einsteinx2
pushed a commit
that referenced
this pull request
May 17, 2022
The `x-mp-kits` header field was previously sending a list of kits that were actively receiving events. Now it will send a list of kits that have been configured, even if they are not actively receiving events due to the SDK state. For example, a kit that was shut down due to the current user's logged-in status not matching its configurations directive previous would not have been included in this list, but now will be included.
mparticle-automation
added a commit
that referenced
this pull request
May 17, 2022
# [8.8.0](v8.7.0...v8.8.0) (2022-05-17) ### Bug Fixes * Fix Dereferenced Garbage Pointer ([#148](#148)) ([d2c58e1](d2c58e1)) * property memory annotations ([#146](#146)) ([c95ddf6](c95ddf6)) * update active kits header ([#147](#147)) ([d196723](d196723)) ### Features * add conformsToProtocol forwarding to MPAppDelegateProxy ([#144](#144)) ([40e517a](40e517a)) * add support for client side rules ([#151](#151)) ([6a93096](6a93096))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The "x-mp-kits" header field was previously sending a list of kits that were actively receiving events. Now it will send a list of kits that have been configured, even if they are not actively receiving events due to the SDK state. For Example, a kit that was shut down due to the current user's logged-in status not matching its configurations directive previous would not have been included in this list but now will be included
Testing Plan
Modified a few existing tests to include checks for the new
[kjitContainer configuredKits]method where the results would differ from[kitContainer activeKits]. Also included a new unit test with a more focused scenario. Updated a networking tests to make sure theconfiguredKitsmethod was properly being applied tox-mp-kitsMaster Issue
Closes https://go.mparticle.com/work/SQDSDKS-3738
Related (Android) PR
mParticle/mparticle-android-sdk#126