Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename notification icons #508

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: rename notification icons #508

merged 1 commit into from
Dec 2, 2024

Conversation

leobel
Copy link
Contributor

@leobel leobel commented Dec 2, 2024

Summary

-Rename new notifications icons to follow naming convention: https://mparticle.github.io/aquarium/iframe.html?viewMode=docs&id=foundations-icons-how-to-use--documentation&globals=#steps-to-add-a-new-icon

Testing Plan

  • Was this tested locally? If not, explain why.
    Screenshot 2024-12-02 at 3 51 13 PM

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@leobel leobel requested a review from tibuurcio December 2, 2024 20:52
Copy link

github-actions bot commented Dec 2, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-02 21:12 UTC

@leobel leobel merged commit 98ea06f into main Dec 2, 2024
9 checks passed
mparticle-automation added a commit that referenced this pull request Dec 6, 2024
## [1.36.1](v1.36.0...v1.36.1) (2024-12-06)

### Bug Fixes

* rename notification icons ([#508](#508)) ([98ea06f](98ea06f))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 1.36.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants