fix: typography component updates #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibuurcio
requested review from
nastyastavitskaya,
jared-dickman,
gabyzif and
danielsiemens
|
Comment on lines
+19
to
+20
| if (size === 'xl') return 20 | ||
| return size |
There was a problem hiding this comment.
I am wondering if we need xs = 10px 🤔
danielsiemens
approved these changes
Nov 20, 2024
|
I'll be waiting on Design review for this one |
gabyzif
approved these changes
Nov 20, 2024
## [1.35.1-fix-typography.1](v1.35.0...v1.35.1-fix-typography.1) (2024-11-20) ### Bug Fixes * typography updates ([f1c7d63](f1c7d63))
| children: 'Example Text', | ||
| type: undefined, | ||
| color: undefined, | ||
| size: 'base', |
| } | ||
|
|
||
| export const Typography = () => { | ||
| return <>DO NOT USE</> |
There was a problem hiding this comment.
...or you'll be fired 😝
nastyastavitskaya
approved these changes
Nov 20, 2024
mparticle-automation
added a commit
that referenced
this pull request
Nov 28, 2024
# [1.36.0](v1.35.0...v1.36.0) (2024-11-28) ### Bug Fixes * typography component updates ([#497](#497)) ([d32d390](d32d390)) ### Features * add abSplit icon ([#499](#499)) ([8776f1c](8776f1c)) * add notificationSubscriptions icon ([#505](#505)) ([b4976bc](b4976bc)) * utilize generics in UserPreferencesService ([#504](#504)) ([4838a86](4838a86))
|
🎉 This PR is included in version 1.36.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the Typography components to better reflect our current customization needs coming from the platforms. It does the following:
sizeprop to generically accept numbers rather then only'base' | 'sm' | 'lg' | 'xl'colorprop work (it wasn't) and provide some auto-complete suggestions for it based onColorTextdesign tokens.tooltipprop to bothTypography.TextandTypography.Linkto be used when those components are used inside a tooltip. Also adds a story for it.Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)