Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move endian_fd reading into nonpure and use generic Reader #10

Closed
m4b opened this issue Oct 8, 2016 · 0 comments
Closed

move endian_fd reading into nonpure and use generic Reader #10

m4b opened this issue Oct 8, 2016 · 0 comments

Comments

@m4b
Copy link
Owner

m4b commented Oct 8, 2016

The idea is that in a non-pure setting, you'll typically always want endian_fd reading, which means we can use the generic Reader trait from std.

This will enable unit testing the endian fd readers by passing Cursor'd byte arrays.

We may be able to drop the no_endian_fd feature flag if this pans out the way I think it can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant