Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unchecked error in updateSchemaRegistry #1694

Closed
justinjc opened this issue Jun 2, 2019 · 1 comment
Closed

Unchecked error in updateSchemaRegistry #1694

justinjc opened this issue Jun 2, 2019 · 1 comment
Assignees
@Haijuncao

Comments

@justinjc
Copy link
Collaborator

justinjc commented Jun 2, 2019

The call here to GetLatestSchema should be checked.
@justinjc justinjc mentioned this issue Jun 2, 2019
Merged
@Haijuncao
Copy link
Contributor

The error here can be NotFound, which is ok, implies curSchema == nil
still, we can be explicit and check for error other than NotFound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Haijuncao Haijuncao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justinjc @Haijuncao @gibbscullen