Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prom_process_collector.go and report process metrics from process reporter #1649

Closed
robskillington opened this issue May 20, 2019 · 0 comments

Comments

@robskillington
Copy link
Collaborator

prom_process_collector.go was introduced to alleviate the fact we removed the default Prometheus collector due to it's excessive load when counting open FDs with processes that had a large number of FDs.

A modified version of the Prometheus process collector was restored to add back stats removed from the fix to avoid reporting open FDs from the Prometheus collector. For more see #1633.

We should remove this modified version of the Prometheus process collector once the M3 process reporter reports the same information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants