Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add id for Annotation update #49

Merged
merged 2 commits into from
Oct 20, 2019
Merged

Add id for Annotation update #49

merged 2 commits into from
Oct 20, 2019

Conversation

lukassup
Copy link

@lukassup lukassup commented Oct 16, 2019

Description

Update Annotations to require id for update method.

Have you written tests?

  • Yes
  • No

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@lukassup lukassup requested a review from m0nhawk as a code owner October 16, 2019 13:48
@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files          15       15           
  Lines         597      597           
=======================================
  Hits          510      510           
  Misses         87       87
Impacted Files Coverage Δ
grafana_api/api/annotations.py 95.31% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53ba83c...5d09eab. Read the comment docs.

Copy link
Owner

@m0nhawk m0nhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the additions! 👍

@m0nhawk m0nhawk merged commit d8d47fc into m0nhawk:master Oct 20, 2019
@lukassup lukassup deleted the annotation-id branch October 24, 2019 13:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants