This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Very minor tweaks #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this conflicts with the import of json, renamed to json_data
this is currently unused, can be readded if needed later
nose needs to be installed to run the tests on a fresh system
|
Hi, Thank you for the PR! I've merged it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed an unused json import, and renamed a variable that was conflicting with that now removed import. I also added nose to the list of packages installed for testing because I needed to install it locally to run the tests in a fresh environment. I can split this up if you want some but not all of it.