Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled internal pullup for CML SYSREF outputs, otherwise there is no signal on them. #1402

Merged
merged 1 commit into from
Dec 7, 2019

Conversation

marmeladapk
Copy link
Contributor

@marmeladapk marmeladapk commented Dec 6, 2019

Signed-off-by: Paweł Kulik [email protected]

ARTIQ Pull Request

Description of Changes

Without setting driver impedance there is no signal on SYSREF outputs. Figure 20. suggests that we should enable internal 100 Ohms when using DC coupling and no external pullups (altough it's not clear to me what they had in mind in this documentation). I checked that ARTIQ now progresses past "DAC sync failed: no sync lock" + that there is a clean clock on SYSREF intputs with 1Vpp swing. Before that change there was no signal and 0V at sysref signals.

Type of Changes

Type
🐛 Bug fix

Steps (Choose relevant, delete irrelevant before submitting)

All Pull Requests

  • Use correct spelling and grammar.
  • Close/update issues.
  • Check the copyright situation of your changes and sign off your patches (git commit --signoff, see copyright).

Code Changes

  • Test your changes or have someone test them. Mention what was tested and how.

Licensing

See copyright & licensing for more info.
ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.

@sbourdeauducq sbourdeauducq merged commit 14e250c into m-labs:master Dec 7, 2019
@sbourdeauducq
Copy link
Member

Thanks!

@sbourdeauducq
Copy link
Member

I checked that ARTIQ now progresses past "DAC sync failed: no sync lock"

That's still a problem on my board, though...

@marmeladapk marmeladapk deleted the hmc7043_fix branch December 9, 2019 10:12
@marmeladapk
Copy link
Contributor Author

@sbourdeauducq Could you try on eb271f3? That's the commit that I was testing on. I also suspect that you may need to clk_src_ext_sel or at least use pullup/down. (Though I didn't require it on my board).

@sbourdeauducq
Copy link
Member

I also suspect that you may need to clk_src_ext_sel or at least use pullup/down.

Thanks.
150a021
But it's having none of it.

@marmeladapk
Copy link
Contributor Author

@sbourdeauducq Could you check if you have any signal on sysref outputs and ADCLK948 output?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants