Enabled internal pullup for CML SYSREF outputs, otherwise there is no signal on them. #1402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paweł Kulik [email protected]
ARTIQ Pull Request
Description of Changes
Without setting driver impedance there is no signal on SYSREF outputs. Figure 20. suggests that we should enable internal 100 Ohms when using DC coupling and no external pullups (altough it's not clear to me what they had in mind in this documentation). I checked that ARTIQ now progresses past "DAC sync failed: no sync lock" + that there is a clean clock on SYSREF intputs with 1Vpp swing. Before that change there was no signal and 0V at sysref signals.
Type of Changes
Steps (Choose relevant, delete irrelevant before submitting)
All Pull Requests
git commit --signoff
, see copyright).Code Changes
Licensing
See copyright & licensing for more info.
ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.