Create data dir if it doesn't exist #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pusher used to handled creating data directories if they didn't already exist. We removed that functionality from Pusher because it seems more appropriate for the producer of a datatype to create its own data directory. However, we found that pcap did not do this. This commit should cause pcap to create its own data directory.
stephen-soltesz
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained
Pull Request Test Coverage Report for Build 40
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pusher used to handled creating data directories if they didn't already exist. We removed that functionality from Pusher because it seems more appropriate for the producer of a datatype to create its own data directory. However, we found that pcap did not do this. This commit should cause pcap to create its own data directory.
This change is