-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure all IPv4 addresses use only 4 bytes. #30
Conversation
Also, convert the eventsocket flag to the one provided in tcpinfo.eventsocket
Pull Request Test Coverage Report for Build 151
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 5 files at r1.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @pboothe and @stephen-soltesz)
tcpinfohandler/handler.go, line 42 at r1 (raw file):
return } if srcIP.To4() != nil {
Please add a comment regarding why this is necessary.
If this logic through the creation of the UUIDEvent below were in a small helper function that helper could be tested pretty easily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 5 files at r1.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @pboothe and @stephen-soltesz)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @pboothe)
Also, convert the
-eventsocket
flag to the one provided intcpinfo.eventsocket
This change is