Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all IPv4 addresses use only 4 bytes. #30

Merged
merged 2 commits into from
Dec 3, 2019
Merged

Ensure all IPv4 addresses use only 4 bytes. #30

merged 2 commits into from
Dec 3, 2019

Conversation

pboothe
Copy link
Contributor

@pboothe pboothe commented Dec 3, 2019

Also, convert the -eventsocket flag to the one provided in tcpinfo.eventsocket


This change is Reviewable

Also, convert the eventsocket flag to the one provided in
tcpinfo.eventsocket
@coveralls
Copy link

coveralls commented Dec 3, 2019

Pull Request Test Coverage Report for Build 151

  • 17 of 17 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 142: 0.0%
Covered Lines: 515
Relevant Lines: 515

💛 - Coveralls

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 5 files at r1.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @pboothe and @stephen-soltesz)


tcpinfohandler/handler.go, line 42 at r1 (raw file):

		return
	}
	if srcIP.To4() != nil {

Please add a comment regarding why this is necessary.

If this logic through the creation of the UUIDEvent below were in a small helper function that helper could be tested pretty easily.

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 5 files at r1.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @pboothe and @stephen-soltesz)

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @pboothe)

@pboothe pboothe merged commit 9f46cd3 into master Dec 3, 2019
@pboothe pboothe deleted the fix-v4 branch December 3, 2019 17:26
@stephen-soltesz
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants