Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log flow id with filename #29

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Log flow id with filename #29

merged 1 commit into from
Dec 3, 2019

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Dec 3, 2019 •
edited by pboothe
Loading

This change is Reviewable

@coveralls
Copy link

Pull Request Test Coverage Report for Build 146

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 142: 0.0%
Covered Lines: 499
Relevant Lines: 499
💛 - Coveralls

pboothe
pboothe approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@pboothe pboothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @pboothe)

@stephen-soltesz stephen-soltesz merged commit 432a143 into master Dec 3, 2019
@pboothe pboothe deleted the sandbox-soltesz-log-flowid branch December 3, 2019 21:39
@stephen-soltesz
Copy link
Contributor Author

https://github.com/m-lab/dev-tracker/issues/442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pboothe pboothe pboothe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephen-soltesz @coveralls @pboothe