Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add api definition for Lookup and Register responses #7

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Add api definition for Lookup and Register responses #7

merged 4 commits into from
Feb 26, 2024

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Feb 26, 2024 •
edited
Loading

This change introduces the api/v0 type definitions for the autojoin API, including the LookupResponse and planned RegisterResponse structs.

This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented Feb 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8052187469

Details

  • 0 of 34 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 7908037130: 0.0%
Covered Lines: 191
Relevant Lines: 191
💛 - Coveralls

cristinaleonr
cristinaleonr approved these changes Feb 26, 2024
View reviewed changes
Copy link

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz
Copy link
Contributor Author

Thank you!

@stephen-soltesz stephen-soltesz merged commit a39bbe5 into main Feb 26, 2024
7 checks passed
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-api-1 branch February 26, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristinaleonr cristinaleonr cristinaleonr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephen-soltesz @coveralls @cristinaleonr