Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: orgadm locate project & register missing credential abort #56

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Fix: orgadm locate project & register missing credential abort #56

merged 2 commits into from
Nov 21, 2024

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Nov 20, 2024 •
edited
Loading

This change fixes one bug and adds a failure condition during register.

  • orgadm needs the Locate API project to authorize a new API key - previously the wrong project was provided to adminx.NewAPIKeys()
  • register now aborts if the Autojoin API Register returns nil credentials. This was allowed only temporarily while the feature was deployed. Jostler depends on these credentials.

This change is Reviewable

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11939136953

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.92%
Totals Coverage Status
Change from base Build 11898866351: 0.0%
Covered Lines: 1191
Relevant Lines: 1204
💛 - Coveralls

@stephen-soltesz
Copy link
Contributor Author

FYI: @nkinkade

robertodauria
robertodauria approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz stephen-soltesz merged commit 61da00e into main Nov 21, 2024
8 checks passed
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-fixes branch November 21, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertodauria robertodauria robertodauria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephen-soltesz @coveralls @robertodauria