Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List support for known servers and script-exporter targets #49

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Oct 16, 2024

This change adds two new formats to the Autojoin.List API

  • format=servers generates a list of all servers known to the API
  • format=script-exporter generates a configuration suitable for targeting the script-exporter

These changes will make it possible to add e2e testing for the byos nodes in sandbox and staging so some measurements are always targeting our development services.

These changes will make it possible to easily list/review all servers known to the Autojoin system.

This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented Oct 16, 2024

Pull Request Test Coverage Report for Build 11446088930

Details

  • 34 of 34 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 98.846%

Totals Coverage Status
Change from base Build 11239589448: 0.02%
Covered Lines: 1114
Relevant Lines: 1127

💛 - Coveralls

@stephen-soltesz stephen-soltesz changed the title List known servers List support for known servers and script-exporter targets Oct 21, 2024
@stephen-soltesz stephen-soltesz marked this pull request as ready for review October 21, 2024 17:47
Copy link
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz stephen-soltesz merged commit 1ad75c4 into main Oct 22, 2024
8 checks passed
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-list-servers branch October 22, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants