Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RegisterDNS to adminx.Org Setup #45

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Sep 10, 2024

This change adds a new method to the adminx.Org to RegisterDNS that ensures the organization DNS zone exists and is configured correctly with in the project wide zone. The organization DNS zone will contain only hostnames dynamically registered by autojoined nodes from that organization.


This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented Sep 10, 2024

Pull Request Test Coverage Report for Build 10797613745

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 98.825%

Totals Coverage Status
Change from base Build 10797083367: 0.02%
Covered Lines: 1093
Relevant Lines: 1106

💛 - Coveralls

@stephen-soltesz stephen-soltesz marked this pull request as ready for review September 10, 2024 17:05
Copy link

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @stephen-soltesz)


cmd/orgadm/main.go line 57 at r2 (raw file):

	o := adminx.NewOrg(project, crmiface.NewCRM(project, crm), sa, sm, d)
	err = o.Setup(ctx, org)
	rtx.Must(err, "failed to setup new organization: "+org)

set up?

Copy link
Contributor Author

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @cristinaleonr)


cmd/orgadm/main.go line 57 at r2 (raw file):

Previously, cristinaleonr (Cristina Leon) wrote…

set up?

Done

@stephen-soltesz stephen-soltesz merged commit d9fdb22 into main Sep 10, 2024
8 checks passed
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-org-dns-2 branch September 10, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants