Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add orgadm for new organization setup #41

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Sep 4, 2024

This change adds a new type adminx.Org and command orgadm to setup a new organization. The setup includes creating service accounts with no keys and secrets with no versions. An organization should be setup once before the first node attempts to Register via the Autojoin API.


This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented Sep 4, 2024

Pull Request Test Coverage Report for Build 10723930805

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 113 of 113 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 98.748%

Totals Coverage Status
Change from base Build 10690968433: 0.2%
Covered Lines: 1025
Relevant Lines: 1038

💛 - Coveralls

@stephen-soltesz stephen-soltesz removed the request for review from nkinkade September 4, 2024 15:57
@stephen-soltesz
Copy link
Contributor Author

Whoops - I forgot about tests for this one - I'll request review again when those are ready

Copy link
Contributor

@nkinkade nkinkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@nkinkade
Copy link
Contributor

nkinkade commented Sep 4, 2024

Oops, I missed your comment before I approve the PR in Reviewable.io. I'll wait for the update.

@stephen-soltesz
Copy link
Contributor Author

PTAL? I have added unit tests now

Copy link
Contributor

@nkinkade nkinkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz stephen-soltesz merged commit 47f4567 into main Sep 5, 2024
8 checks passed
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-setup branch September 5, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants