Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release needed to fix issues in other dependent projects #98

Closed
ayappanec opened this issue Apr 25, 2017 · 17 comments
Closed

New release needed to fix issues in other dependent projects #98

ayappanec opened this issue Apr 25, 2017 · 17 comments

Comments

@ayappanec
Copy link

Projects like spark , kafka etc uses lz4-java artifact from central maven repository and the older releases don't have support for more platforms. So issues are seen in platforms which don't have support. Since the scenario has changed recently with lz4-java supporting more platforms , a new release will help a lot. Thanks.

@odaira
Copy link
Member

odaira commented Apr 25, 2017

Once I merge all the necessary PRs and fix important issues, I plan to release a new version, probably sometime in May.

@danielfree
Copy link
Contributor

@odaira It's great to see the restart of development. I think the frame format 1.5 would be an important feature for the next release, similar to #61 did, also can be found at https://github.com/danielfree/lz4-java and a further development is done at https://github.com/nathants/java-lz4

@odaira
Copy link
Member

odaira commented May 4, 2017

@danielfree Do you have any recommendation for which implementation of the frame support I should take a look at?

@danielfree
Copy link
Contributor

@odaira My fork (credit goes to @gyscos) and https://github.com/nathants/java-lz4 contain only JNI implementation, while #61 is Java implementation, so it depends on which one we need.

There are still some issues in the JNI implementation, e.g. the available() method is not what it should be for an arbitrary length file, as well as the skip() method - I think these methods should represent the whole file instead of one buffer/block.

@odaira
Copy link
Member

odaira commented May 22, 2017

Thanks, I have reviewed and merged #61, as the platform independence should be the first priority.

@ayappanec
Copy link
Author

@odaira Any update on this ?

@odaira
Copy link
Member

odaira commented Jun 12, 2017

I think these are my TODOs:

@maropu
Copy link
Contributor

maropu commented Jun 23, 2017

Hi, I'm interested in #76. If nobody takes on this , could I take over this (e.g., apply review and add tests, ...)?

@maropu
Copy link
Contributor

maropu commented Jun 25, 2017

I checked this patch (master...maropu:ConcatByteStream) fixed the issue described in #76 and passed related tests in spark (e.g., compression and shuffling stuffs).

@odaira
Copy link
Member

odaira commented Jun 26, 2017

@maropu that would be great! Are you going to submit a new PR?

@maropu
Copy link
Contributor

maropu commented Jun 26, 2017

@odaira ok, I'll do, thanks!

@maropu
Copy link
Contributor

maropu commented Jun 26, 2017

Could u check #105? Thanks!

@odaira
Copy link
Member

odaira commented Jul 13, 2017

I think I am done with my TODOs. Code-wise, we are ready to release the next version.

I can use Java 8's javac to build a jar file for distribution, can't I? Java 7 is no longer publicly updated, and we don't need to consider Java 7 users.

@maropu
Copy link
Contributor

maropu commented Jul 14, 2017

Spark v2.2 already removed java7, so it's okay for that.

@ijuma
Copy link

ijuma commented Jul 22, 2017

Kafka still supports Java 7, so it would be great if the release was built with Java 7.

@odaira
Copy link
Member

odaira commented Aug 22, 2017

Released 1.4.0. Used javac from Java 7.

@odaira odaira closed this as completed Aug 22, 2017
@ijuma
Copy link

ijuma commented Aug 22, 2017

Thanks! We are already using it in kafka trunk. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants