Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled rejection on failed login, even with catch() #370

Open
peicodes opened this issue May 2, 2018 · 0 comments
Open

Unhandled rejection on failed login, even with catch() #370

peicodes opened this issue May 2, 2018 · 0 comments

Comments

@peicodes
Copy link

peicodes commented May 2, 2018

When I use catch() to handle a rejection caused by invalid login credentials, angular will still warn about an unhandled rejection. I believe the line that causes this is:

return $q.reject(resp);

This rejection doesn't actually get returned anywhere. The promise being returned by the submitLogin function is returning a different promise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant